Optimize: Skip setting quota when unchanged#855
Open
Treetoo wants to merge 1 commit intoCESNET:mainfrom
Open
Conversation
Treetoo
commented
Feb 25, 2026
Treetoo
commented
- do not set quota if it is unchanged
- do not set quotas for expired users
- fix: first create directories, then set quotas
- fix typo: "$QUOTA_ENABLED_FILE}" to "$QUOTA_ENABLED_FILE"
- do not set quota if it is unchanged - do not set quotas for expired users - fix: first create directories, then set quotas - fix typo: "$QUOTA_ENABLED_FILE}" to "$QUOTA_ENABLED_FILE"
zlamalp
requested changes
Mar 10, 2026
Contributor
zlamalp
left a comment
zlamalp
left a comment
There was a problem hiding this comment.
Hi,
first thank you for this PR!
Unfortunately, GitHub is used only as public mirror. We accept merge requests at our GitLab repository: https://gitlab.ics.muni.cz/perun/perun-idm/perun-services
Please make your contribution on GitLab and be sure to read contributing guides.
Change/code itself is OK by me and Zdeněk told me it has been already tested on production environment. Just a few notes:
- We use conventional commits and semantic release so first line of commit message should be like
feat(fs_home): skip setting quota when unchanged. - Please update also
changelogfile, which is used to generate new version of deb/rpm packages when this change gets released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.